Requests.exceptions.http error not handled by praw #1825 #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-in-praw Handle media upload HTTP errors consistently
bboe
reviewed
Sep 20, 2025
| response.raise_for_status() | ||
| try: | ||
| response.raise_for_status() | ||
| except HTTPError as err: |
There was a problem hiding this comment.
Could you call this error please here and in the other locations.
bboe
reviewed
Sep 20, 2025
| http_response.status_code = 500 | ||
|
|
||
| response = mock.Mock() | ||
| response.ok = True |
bboe
requested changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wrapped stylesheet, emoji, and widget media uploads in try/except blocks so AWS HTTP failures raise prawcore.ServerError instead of surfacing raw HTTPError exceptions.
Added regression tests covering 500 responses for stylesheet assets, emoji uploads, and widget image uploads to guarantee these helpers emit ServerError exceptions.
Testing
✅ python -m pytest tests/unit/models/reddit/test_subreddit.py tests/unit/models/reddit/test_emoji.py tests/unit/models/reddit/test_widgets.py
Fixes issue #1825