ledger support - #320
Closed
turbocrime wants to merge 8 commits into
Closed
Conversation
Collaborator
Author
|
TODO: ensure wallet creation height is not set |
Collaborator
Author
|
TODO: ensure wallet creation height includes chain name |
turbocrime
commented
Apr 28, 2025
|
|
||
| async sign( | ||
| plan: PartialMessage<TransactionPlan>, | ||
| metadata?: string[], |
turbocrime
commented
Apr 28, 2025
Collaborator
Author
There was a problem hiding this comment.
replace with an imported bech32m implementation
turbocrime
commented
Apr 28, 2025
turbocrime
commented
Apr 28, 2025
Collaborator
Author
There was a problem hiding this comment.
add toast directing user attention to authorization
turbocrime
commented
Apr 28, 2025
Comment on lines
+7
to
+9
| // TODO: retrieve from storage/config | ||
| //const activeMethods = new Set(['prax', 'ledger']); | ||
| const activeMethods = new Set(['ledger']); |
Collaborator
Author
There was a problem hiding this comment.
rm constant, use correct auth for wallet
turbocrime
commented
Apr 28, 2025
Comment on lines
+11
to
+12
| const methods = []; | ||
| for (const methodName of activeMethods) { |
Collaborator
Author
There was a problem hiding this comment.
does not need to be a loop
turbocrime
commented
Apr 28, 2025
turbocrime
commented
Apr 28, 2025
Collaborator
Author
There was a problem hiding this comment.
improve welcome ui
turbocrime
commented
Apr 28, 2025
Collaborator
Author
There was a problem hiding this comment.
revert some of this
turbocrime
commented
Apr 28, 2025
Comment on lines
+36
to
+39
| const migrateNumeraires = ( | ||
| numeraires: V1LocalStorageState['numeraires'], | ||
| ): V2LocalStorageState['numeraires'] => | ||
| numeraires.map(n => bech32mAssetId(AssetId.fromJsonString(n))); |
Collaborator
Author
There was a problem hiding this comment.
don't change numeraires format
Collaborator
Author
|
closing in favor of smaller changesets beginning with #400 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on penumbra-zone/web#2229
successfully signs transactions requested by frontend.
ui is not amazing, onboarding may be fragile.
required more significant storage refactor than i expected, due to many assumptions about the availability of a seed phrase. i want to split this out into phases.