Use attached popup - #375
Open
turbocrime wants to merge 1 commit into
Open
Conversation
turbocrime
force-pushed
the
use-open-popup-countdown
branch
from
August 19, 2025 00:13
af07cf6 to
e96a1be
Compare
turbocrime
marked this pull request as ready for review
August 19, 2025 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors popup handling to use attached popups instead of creating new windows where feasible. This improves the user experience by keeping approval dialogs contextually connected to the originating tab.
The transaction approval popup still does not appear attached, due to the lack of sender information at the call site.
Changes