Ledger UI: Authorization - #403
Open
turbocrime wants to merge 1 commit into
Open
Conversation
TalDerei
approved these changes
Aug 28, 2025
TalDerei
left a comment
TalDerei
left a comment
Contributor
There was a problem hiding this comment.
optimistically 👍
quite a few organizational changes here, with helpers split into separate files — but that looks fine.
Comment on lines
+81
to
+87
| // }) satisfies LockGrantedCallback; | ||
|
|
||
| // return (await navigator.locks.request( | ||
| // `custody-${this.label}-${bech32mWalletId(this.id)}`, | ||
| // { mode: 'exclusive' }, | ||
| // lockGrantedCallback, | ||
| // )) as never; |
| import { throwIfNeedsLogin } from '../needs-login'; | ||
| import { popup } from '../popup'; | ||
|
|
||
| export const getAuthorization = async (plan: TransactionPlan): Promise<AuthorizationData> => { |
Contributor
There was a problem hiding this comment.
comment: general organizational question here – any downstream side-effects of relocating signing from background script to directly being owned by the popup context?
Comment on lines
-29
to
-32
| .catch(error => { | ||
| console.error(error); | ||
| throw new ConnectError('Approval failed', Code.Internal); | ||
| }); |
Contributor
There was a problem hiding this comment.
comment: if the user denies or the popup throws, popup should reject. why are we removing this, doesn't returning an error instead of rejecting crash on response!.authorizeResponse?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the authorization slice changes split out from PR #402. It implements the core transaction authorization flow updates needed to support Ledger hardware wallet signing through the custody abstraction.
Note that to access usb devices, authorization is now performed directly within the popup.
This PR focuses specifically on the authorization logic changes, while the UI components and onboarding flows remain in PR #402.