registry: let downstream override base url - #118
Draft
erwanor wants to merge 2 commits into
Draft
Conversation
|
vacekj
approved these changes
Jan 21, 2025
vacekj
left a comment
vacekj
left a comment
Member
There was a problem hiding this comment.
just needs a reformat then lgtm.
Contributor
|
Still needs rebase. Looks like #119 might land first, so make sure to re-pull main. |
erwanor
marked this pull request as draft
January 21, 2025 22:13
Contributor
Author
|
This is untested so setting this PR as a draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploring if this is feasible. The reason why this is desirable is that this would let us experiment with custom registries on a whim, for example, if we are setting up devnet with custom channels.
Without this, it's near impossible to use registry downstreams on custom networks.
Not tested