Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring an installation script #88

Closed
wants to merge 2 commits into from

Conversation

alanorozco
Copy link
Contributor

In some environments, an installation script must be specified to limit the amount of dependencies.

We have a monorepo in our case, in which the build dependencies are scoped to different packages.

As a result, npm ci is much slower than our custom build-only install script. A full install takes about ~60s, whereas a build-only install takes about ~5s. Our builds take less than 5s, so the ability to configure install would reduce our total time to run compressed-size-action from ~130s to less than 20s.

@alanorozco
Copy link
Contributor Author

I see now that #85 attempts the same thing in a slightly different way.

Would love to hear feedback about the overall feature. Either of the two changes would be a huge boon for us! :)

@nicklmart
Copy link

also have a need for this, would like to run npm ci --ignore-scripts instead of npm ci

@PixnBits PixnBits mentioned this pull request Sep 5, 2023
@xaviermariaconejo
Copy link

Also need this here. I haven't seen this PR and I created another one 😂 #99

¿What was your solution guys?

@rschristian
Copy link
Member

rschristian commented Apr 22, 2024

Closing in favor of #85

Edit: I did largely copy your docs over though, thanks for writing them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants