-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 #17
Draft
rschristian
wants to merge
9
commits into
main
Choose a base branch
from
v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v3 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c624b01
to
b6f13d1
Compare
1f2b71d
to
3b0bd37
Compare
781b472
to
eafea6e
Compare
5802816
to
84811ca
Compare
9d31f42
to
379f6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideas for v3, as I'll forget them otherwise. Certainly not set in stone if anyone has concerns or other ideas. Feedback welcome and appreciated!
./prerender
/prerender
, and only offer the prerender script through it to avoid some headaches with the RTS optional peer dep (see fix: RTS peer dep w/ Vite #13)hydrate()
exportsrender()
andhydrate()
internally and only functions correctly if used w/ iso'sprerender()
.useRoute
anduseLocation
useLocation
anduseRoute
have some overlapping properties and can end up firing between renders, leading to tearing. Consolidating down is ideal IMO.useRoute().params
->pathParams
&useRoute().query
->searchParams
vue-router
in our naming but personally I dislike the ambiguity (params
can easily refer to both path parameters & query parameters) and a few people I've spoken to seem to agree. These seem to be better & immediately understandable to anyone, regardless of which routers they've used in the past.To Do:
useLocation().url
anduseLocation().path
will just about always matchTo Think About: