Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nested routes, and a base prop to start from if necessary #100

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup nested route tests in dom
  • Loading branch information
sskoopa committed Dec 18, 2016
commit bf1dd22339126e1c113c7e40b1e2b6f82afc4db0
12 changes: 7 additions & 5 deletions test/dom.js
Original file line number Diff line number Diff line change
@@ -136,10 +136,10 @@ describe('dom', () => {
sinon.spy(Y.prototype, 'componentWillMount');
sinon.spy(Y.prototype, 'componentWillUnmount');
mount(
<Router base='/app'>
<Router base="/app">
<X path="/x" />
<Router default>
<Y path='/y'/>
<Y path="/y"/>
</Router>
</Router>
);
@@ -175,9 +175,11 @@ describe('dom', () => {
mount(
<Router base='/baz'>
<X path="/j" />
<Router path='/box'>
<Y path='/k'/>
</Router>
<z path="/box/:bar*">
<Router base="/box">
<Y path="/k"/>
</Router>
</z>
</Router>
);
expect(X.prototype.componentWillMount).not.to.have.been.called;