Skip to content

Fix:Remove hidden visibility from current menu item #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix:Remove hidden visibility from current menu item #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/components/header/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@
padding: 0;
}

&.current {
visibility: hidden;
}

Comment on lines -144 to -147
Copy link
Member

@rschristian rschristian Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Performance", or personal aesthetic preferences? There's a very large difference between the PR description and the actual changes, at least in English. Might just be a translation issue but wanted to ask in case I'm misunderstanding you.

Whilst I do prefer always showing the branding/home link on sites I create, I don't think we should be changing this just for personal preference. However, we have spoken in the past about heading styling issues on certain screen sizes (I think near 1000px wide is a bad one) and those I'd absolutely love fixes for, just don't have time myself.

Copy link
Contributor Author

@SisyphusZheng SisyphusZheng Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Performance", or personal aesthetic preferences? There's a very large difference between the PR description and the actual changes, at least in English. Might just be a translation issue but wanted to ask in case I'm misunderstanding you.

Whilst I do prefer always showing the branding/home link on sites I create, I don't think we should be changing this just for personal preference. However, we have spoken in the past about heading styling issues on certain screen sizes (I think near 1000px wide is a bad one) and those I'd absolutely love fixes for, just don't have time myself.

Oh,what I mean is that there is a gap in the "head" section when displayed on mobile devices(before-1-picture), which doesn't look very aesthetically pleasing. I just want to fix this issue, and displaying the logo directly is simply because this method is more straightforward.

Copy link
Member

@rschristian rschristian Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gap is quite intentional though, I don't think we need to collapse it/fill in the space necessarily.

If you did really want this, I'd say it should be limited to mobile only & should not have the "current" style applied to it as that looks not great, IMO.

svg {
position: relative;
padding-right: 5px;
Expand Down