refactor: config file TBD #1348
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +61 B (+0.01%) Total Size: 449 kB
ℹ️ View Unchanged
|
rschristian
commented
Oct 10, 2025
Comment on lines
+3
to
+20
| const LOGOS = [ | ||
| { | ||
| name: 'logo-text', | ||
| alt: 'Full Logo' | ||
| }, | ||
| { | ||
| name: 'logo-text-inverted', | ||
| alt: 'Full Logo with Inverted Colors' | ||
| }, | ||
| { | ||
| name: 'symbol', | ||
| alt: 'Preact Symbol' | ||
| }, | ||
| { | ||
| name: 'symbol-inverted', | ||
| alt: 'Preact Symbol with Inverted Colors' | ||
| } | ||
| ]; |
There was a problem hiding this comment.
Hoisting this out of the component made little sense, this was the only consumer (I wrote this, to be clear -- dunno why I did, but I did)
Comment on lines
-59
to
+76
| "tutorial": { | ||
| "begin": { | ||
| "en": "Begin Tutorial", | ||
| "kr": "튜토리얼 시작", | ||
| "ru": "Начать обучение", | ||
| "zh": "开始教程" | ||
| }, | ||
| "help": { | ||
| "en": "Help", | ||
| "ja": "助ける", | ||
| "kr": "정답 확인", | ||
| "ru": "Помощь", | ||
| "zh": "帮助" | ||
| }, | ||
| "solve": { | ||
| "en": "Solve", | ||
| "ja": "説き明かす", | ||
| "ru": "Решить", | ||
| "zh": "解决" | ||
| } | ||
| "beginTutorial": { | ||
| "en": "Begin Tutorial", | ||
| "kr": "튜토리얼 시작", | ||
| "ru": "Начать обучение", | ||
| "zh": "开始教程" | ||
| }, | ||
| "help": { | ||
| "en": "Help", | ||
| "ja": "助ける", | ||
| "kr": "정답 확인", | ||
| "ru": "Помощь", | ||
| "zh": "帮助" | ||
| }, | ||
| "solve": { | ||
| "en": "Solve", | ||
| "ja": "説き明かす", | ||
| "ru": "Решить", | ||
| "zh": "解决" |
There was a problem hiding this comment.
Flattening this out makes it a bit easier & more consistent to access (useTranslation) for little loss; the nesting only gives an indication of where the string is used, nothing essential.
Comment on lines
-36
to
-61
| function SiblingNav({ route, lang, start }) { | ||
| let title = ''; | ||
| let url = ''; | ||
| if (route) { | ||
| url = route.path.toLowerCase(); | ||
| title = | ||
| typeof route.name === 'object' | ||
| ? route.name[lang || 'en'] | ||
| : route.name || route.title; | ||
| } | ||
| const label = useTranslation(start ? 'previous' : 'next'); | ||
|
|
||
| return ( | ||
| <a class={style.nextLink} data-dir-end={!start} href={url}> | ||
| {start && <span class={style.icon}>← </span>} | ||
| {!start && <span class={style.icon}> →</span>} | ||
| <span class={style.nextInner}> | ||
| <span class={style.nextTitle}> | ||
| <span class={style.nextTitleInner}>{title}</span> | ||
| </span> | ||
| <span class={style.nextUrl}>{label}</span> | ||
| </span> | ||
| </a> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Whilst looking at our use of useTranslation I came across this which seems to have been long unused. Created in #650 but removed at some point, this is all unused.
| "zh": "简体中文" | ||
| }, | ||
| "repo": "preact", | ||
| "repo": "preactjs/preact", |
There was a problem hiding this comment.
Not against just inlining the string altogether, but if we do have it hoisted to our app-wide config, feels like org + repo makes more sense.
rschristian
force-pushed
the
refactor/config-file
branch
from
5aaa6ef to
325eeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.