chore: Misc cleaning #1349
Open
chore: Misc cleaning #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -521 B (-0.12%) Total Size: 449 kB
ℹ️ View Unchanged
|
rschristian
force-pushed
the
chore/misc-clean
branch
from
81685a2 to
8edfc63
Compare
rschristian
commented
Oct 18, 2025
Comment on lines
-87
to
-100
| {hasNav && ( | ||
| <div class={style.nextWrapper}> | ||
| {props.prev ? ( | ||
| <SiblingNav start lang={props.lang} route={props.prev} /> | ||
| ) : ( | ||
| <span /> | ||
| )} | ||
| {props.next ? ( | ||
| <SiblingNav lang={props.lang} route={props.next} /> | ||
| ) : ( | ||
| <span /> | ||
| )} | ||
| </div> | ||
| )} |
Member
Author
There was a problem hiding this comment.
Created in #650 but removed at some point, this is all unused.
Comment on lines
+3
to
+20
| const LOGOS = [ | ||
| { | ||
| name: 'logo-text', | ||
| alt: 'Full Logo' | ||
| }, | ||
| { | ||
| name: 'logo-text-inverted', | ||
| alt: 'Full Logo with Inverted Colors' | ||
| }, | ||
| { | ||
| name: 'symbol', | ||
| alt: 'Preact Symbol' | ||
| }, | ||
| { | ||
| name: 'symbol-inverted', | ||
| alt: 'Preact Symbol with Inverted Colors' | ||
| } | ||
| ]; |
Member
Author
There was a problem hiding this comment.
No idea why past me hoisted this into the app config, that was silly. It's only ever used here, no need for that to be accessible app-wide.
rschristian
force-pushed
the
chore/misc-clean
branch
from
8edfc63 to
9f7b830
Compare
rschristian
commented
Oct 19, 2025
| }, | ||
| image({ href, text }) { | ||
| return `<img decoding="async" src="${href}" alt="${text}" />`; | ||
| return `<img loading="lazy" decoding="async" src="${href}" alt="${text}" />`; |
Member
Author
There was a problem hiding this comment.
We don't have many pages with images but this seems like a no-brainer. Was copied here from content-region last year, didn't have lazy loading set there either. Dunno why.
rschristian
commented
Oct 19, 2025
| * Button that expands into a menu when clicked. Pass in label & menu items as children. | ||
| * | ||
| * @param {ExpandableNavLinkProps & import('preact').JSX.ButtonHTMLAttributes} props | ||
| * @param {ExpandableNavLinkProps & import('preact').ButtonHTMLAttributes} props |
Member
Author
There was a problem hiding this comment.
Broken when we upgraded to Preact v11 here.
|
|
||
| /** | ||
| * @param {NavLinkProps & import('preact').AnchorHTMLAttributes} props | ||
| * @param {NavLinkProps & Omit<import('preact').AnchorHTMLAttributes, 'role'>} props |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor things that I've been carrying in my git stash for too long