Skip to content

Conversation

@marki1an
Copy link
Collaborator

@marki1an marki1an commented Apr 10, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an added enhancement New improvement do not merge Not the time for merging yet tests Functional or other tests labels Apr 10, 2025
@marki1an marki1an self-assigned this Apr 10, 2025
@marki1an marki1an requested a review from osulzhenko April 10, 2025 15:25
@marki1an marki1an changed the title Test: Update pr-java-ci work flow Test: Update pr-java/functional-ci work flow Apr 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

TestsPassed ☑️Skipped ⚠️Failed ❌️
JUnit Test Report8333 ran8328 passed2 skipped3 failed

osulzhenko
osulzhenko previously approved these changes Nov 5, 2025
@osulzhenko
Copy link
Collaborator

in WIP status

@prebid prebid deleted a comment from github-actions bot Nov 14, 2025
@prebid prebid deleted a comment from github-actions bot Nov 14, 2025
@prebid prebid deleted a comment from github-actions bot Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants