IX Adapter feature dynamic account id support #4218
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,11 +68,16 @@ public class IxBidder implements Bidder<BidRequest> { | |
| private static final String PBS_VERSION_UNKNOWN = "unknown"; | ||
|
|
||
| private final String endpointUrl; | ||
| private final String defaultAccountId; | ||
| private final PrebidVersionProvider prebidVersionProvider; | ||
| private final JacksonMapper mapper; | ||
|
|
||
| public IxBidder(String endpointUrl, | ||
| String defaultAccountId, | ||
| PrebidVersionProvider prebidVersionProvider, | ||
| JacksonMapper mapper) { | ||
|
Comment on lines
+75
to
+78
Collaborator
There was a problem hiding this comment. please add an empty line between lines 78 and 79 (according to the repo's code style) |
||
| this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); | ||
| this.defaultAccountId = (defaultAccountId != null) ? defaultAccountId : ""; | ||
|
Collaborator
There was a problem hiding this comment.
|
||
| this.prebidVersionProvider = Objects.requireNonNull(prebidVersionProvider); | ||
| this.mapper = Objects.requireNonNull(mapper); | ||
| } | ||
|
|
@@ -82,6 +87,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ | |
| final Set<String> siteIds = new HashSet<>(); | ||
| final List<Imp> imps = new ArrayList<>(); | ||
| final List<BidderError> errors = new ArrayList<>(); | ||
| final Set<String> accountIds = new HashSet<>(); | ||
|
|
||
| for (Imp imp : bidRequest.getImp()) { | ||
| try { | ||
|
|
@@ -91,6 +97,11 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ | |
| siteIds.add(siteId); | ||
| } | ||
|
|
||
| final String accountId = impExt.getAccountId(); | ||
| if (StringUtils.isNotEmpty(accountId)) { | ||
| accountIds.add(accountId); | ||
| } | ||
|
Collaborator
There was a problem hiding this comment. looks like the set of accounts isn't really needed please replace the final String accountId = impExt.getAccountId();
if (StringUtils.isNotEmpty(accountId)) {
accountIds.add(accountId);
}with the accountId = accountId == null ? impExt.getAccountId() : accountId; |
||
|
|
||
| imps.add(modifyImp(imp, impExt)); | ||
| } catch (PreBidException e) { | ||
| errors.add(BidderError.badInput(e.getMessage())); | ||
|
|
@@ -102,12 +113,24 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ | |
| } | ||
|
|
||
| final BidRequest modifiedBidRequest = modifyBidRequest(bidRequest, imps, siteIds); | ||
|
|
||
| final String resolvedAccountId = accountIds.isEmpty() | ||
| ? null | ||
| : accountIds.iterator().next(); | ||
|
Comment on lines
+117
to
+119
Collaborator
There was a problem hiding this comment. This code is not needed after implementing https://github.com/prebid/prebid-server-java/pull/4218/files#r2406121593 |
||
|
|
||
| final String resolvedEndpoint = resolveEndpointMacro(endpointUrl, resolvedAccountId); | ||
|
|
||
| final List<HttpRequest<BidRequest>> httpRequests = Collections.singletonList( | ||
| BidderUtil.defaultRequest(modifiedBidRequest, resolvedEndpoint, mapper)); | ||
|
|
||
| return Result.of(httpRequests, errors); | ||
| } | ||
|
|
||
| private String resolveEndpointMacro(String endpoint, String accountId) { | ||
| final String resolvedAccountId = StringUtils.isNotEmpty(accountId) ? accountId : this.defaultAccountId; | ||
| return endpoint.replace("${IX_ACCOUNT_ID}", resolvedAccountId); | ||
|
Collaborator
There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| private ExtImpIx parseImpExt(Imp imp) { | ||
| try { | ||
| return mapper.mapper().convertValue(imp.getExt(), IX_EXT_TYPE_REFERENCE).getBidder(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please format the parameters list