Tests: Support GET interface profiles #4239
Conversation
marki1an
left a comment
marki1an
left a comment
There was a problem hiding this comment.
Please add validation for get parameters
| @JsonProperty("sarid") | ||
| String storedAuctionResponseId | ||
|
|
||
| @JsonProperty("mimes") |
There was a problem hiding this comment.
No, really needed here JsonProperty
| @JsonProperty("oh") | ||
| Integer originalHeight | ||
|
|
||
| @JsonProperty("sizes") |
| @JsonProperty("ms") | ||
| Object sizesLegacy | ||
|
|
||
| @JsonProperty("slot") |
There was a problem hiding this comment.
Check for similar occurrences
| List<Integer> api | ||
|
|
||
| @JsonProperty("battr") | ||
| List<Integer> battr |
There was a problem hiding this comment.
Better naming for it blockAttributes
| Integer podSequence | ||
|
|
||
| @JsonProperty("proto") | ||
| List<Integer> proto |
There was a problem hiding this comment.
Please rename to protocols
| and: "Bidder request should contain mimes from param" | ||
| def bidderRequest = bidder.getBidderRequest(request.id) | ||
| assert bidderRequest.imp.size() == 1 | ||
| assert bidderRequest.imp.first.getProperty(impMediaType.value).mimes == [mimes] |
There was a problem hiding this comment.
I'd like to propose creating a utility method to get this field, since we will often use it, and it will be faster than using getProperty.
There was a problem hiding this comment.
Add in where block null value when mimes not defined.
Comment applicable to all tests
| impMediaType << [ | ||
| MediaType.BANNER, | ||
| MediaType.VIDEO, | ||
| MediaType.AUDIO | ||
| ] |
| it.mimes = [mimes] | ||
| } | ||
|
|
||
| "Default stored request" |
| } | ||
| } | ||
|
|
||
| def "PBS should apply ow and oh for banner imp from general get request when it's specified"() { |
There was a problem hiding this comment.
You can merge with PBS should apply width and height for banner imp from general get request when it's specified
| and: "Default bid response" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(request) | ||
| bidder.setResponse(request.id, bidResponse) |
There was a problem hiding this comment.
You can remove bid response since it's present in BaseSpec
There was a problem hiding this comment.
Please take a look at this comment
| and: "Default bid response" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(request) | ||
| bidder.setResponse(request.id, bidResponse) |
There was a problem hiding this comment.
Please take a look at this comment
| given: "Default General get request" | ||
| def validMemis = PBSUtils.randomString | ||
| def generalGetRequest = GeneralGetRequest.default.tap { | ||
| it.mimes = (invalidMimes + validMemis) |
There was a problem hiding this comment.
What about "$invalid $valid"?
|
|
||
| def "PBS should apply width and height for banner imp from general get request when banner width and height are square dimensions"() { | ||
| given: "Default General get request" | ||
| def side = PBSUtils.getRandomNumber(0, 10) |
|
|
||
| def "PBS should apply sizes banner imp from general get request when banner width and height are square dimensions"() { | ||
| given: "Default General get request" | ||
| def side = PBSUtils.getRandomNumber(0, 10) |
| impMediaType << [ | ||
| MediaType.VIDEO, | ||
| MediaType.AUDIO | ||
| ] |
There was a problem hiding this comment.
| impMediaType << [ | |
| MediaType.VIDEO, | |
| MediaType.AUDIO | |
| ] | |
| impMediaType << [MediaType.VIDEO, MediaType.AUDIO] |
| ] | ||
| } | ||
|
|
||
| def "PBS should apply api from general get request when it's specified"() { |
There was a problem hiding this comment.
It would be nice to see all tests with a negative scenario when not specified
| and: "Default bid response" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(request) | ||
| bidder.setResponse(request.id, bidResponse) |
| assert bidderRequest.imp.first.video.linearity == linearityParam | ||
| } | ||
|
|
||
| def "PBS should apply minbr from general get request when it's specified"() { |
There was a problem hiding this comment.
PBS should apply minbr and maxbr from general get request when it's specified
| assert !response.ext?.errors | ||
| assert !response.ext?.warnings | ||
|
|
||
| and: "Bidder request should contain boxingallowed from param" |
| assert !response.ext?.errors | ||
| assert !response.ext?.warnings | ||
|
|
||
| and: "Bidder request should contain boxingallowed from param" |
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check