Location lists - #18
Merged
Merged
Conversation
Change `from-/to-location-name` → `from-/to-location-names` (note the 's' at the end).
Updaet to allow lists in `from-/to-location-names`. The preprocessing method is now redundant.
Move the preprocessing and validation logic to a new class.
New validation and preprocessing logic.
Update to new reader and processing.
This scenario is not correct anymore. Now it is supposed to cause an error. This error is already checked in "preprocessing/exchange_loop"
This was
linked to
issues
Aug 29, 2026
Update the description for new tags
Draft
uekerman
approved these changes
Aug 31, 2026
uekerman
left a comment
uekerman
left a comment
Member
There was a problem hiding this comment.
I only had a very brief look, but this looks like what I had in mind. Thanks!
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #17 .
This also resolves #6 .
The topology's tags
from-/to-location-nameare nowfrom-/to-location-names(note the 's' at the end). This means that they are now also expected to be of type "array" and contain "string" entries.This was requested by @uekerman .
There is also a test for this under
tests/adapter_config_generation/location_lists/Technical changes
TopologyProcessor_data_preprocessing()inTopologyReaderhas been removed (it was actively working against allowing location-lists 😔)