Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor control flow #34

Merged
merged 12 commits into from
Nov 27, 2019
Merged

WIP: Refactor control flow #34

merged 12 commits into from
Nov 27, 2019

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Apr 29, 2019 •
edited
Loading

Working on #33 in this PR

@BenjaminRodenberg BenjaminRodenberg self-assigned this Apr 29, 2019
BenjaminRodenberg added a commit that referenced this pull request Apr 29, 2019
@BenjaminRodenberg
merge current progress of #34 into this branch
5b262a6
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Oct 19, 2019
Open
@BenjaminRodenberg
Copy link
Member Author

Since we already introduced the Solverstate in this PR, let's do it properly: We sometimes need a solverstate that consist of multiple fields (see precice/tutorials#50). A prototype implementation can be found on 61c8e2a.

@BenjaminRodenberg
Copy link
Member Author

BenjaminRodenberg commented Oct 19, 2019 •
edited
Loading

We should also use the is_timestep_complete API function: see 2b0cc64 and f6b5032

Edit: Done in c2e3125

BenjaminRodenberg
BenjaminRodenberg commented Nov 27, 2019
View reviewed changes
Copy link
Member Author

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the current state the unit tests work and the code additions look reasonable.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review November 27, 2019 00:41
@BenjaminRodenberg BenjaminRodenberg merged commit 550ca38 into master Nov 27, 2019
@BenjaminRodenberg BenjaminRodenberg deleted the refactorControlFlow branch November 27, 2019 07:51
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenjaminRodenberg BenjaminRodenberg

@IshaanDesai IshaanDesai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminRodenberg @IshaanDesai