Skip to content

Conversation

@MakisH
Copy link
Member

@MakisH MakisH commented Nov 20, 2025

Restricts the NumPy version to 1 and fmpy version to one of the versions documented in https://github.com/precice/fmi-runner/blob/main/docs/README.md, since fmpy now uses NumPy 2.

Still testing.

@MakisH MakisH self-assigned this Nov 20, 2025
@uekerman
Copy link
Member

uekerman commented Dec 5, 2025

I guess you needed this on Ubuntu 24.04?

@MakisH
Copy link
Member Author

MakisH commented Dec 5, 2025

This should be independent of the OS version, as the packages come from pip.
Note that, due to caching, if a previous version is already installed or available locally, pip will prefer that, unless explicitly upgraded. The issue with fresh installs.

@uekerman uekerman force-pushed the restrict-requirements branch from 430a7fd to 0453840 Compare December 8, 2025 08:52
@uekerman
Copy link
Member

uekerman commented Dec 8, 2025

I fixed the tests on main and rebased here.

@uekerman
Copy link
Member

uekerman commented Dec 8, 2025

Tests are running through now, but also did on main. Is this also a caching "feature"?

@MakisH
Copy link
Member Author

MakisH commented Dec 8, 2025

I don't see the previous test output anymore after the force-push, so I cannot see the logs. But none of the workflows in this repository uses any caching between test jobs.

Do you remember what the logs said?

@MakisH
Copy link
Member Author

MakisH commented Dec 8, 2025

Found it:

error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

This is unrelated to this PR, and fixed by #17

@MakisH
Copy link
Member Author

MakisH commented Dec 8, 2025

Ah, I understand now what you meant. The tests work with NumPy 2, so the whole package is fine, and this PR is not needed per se.

The issue is that other python-based packages we use require NumPy 1, so installing them all in the same venv would fail. But this is more of an issue on the other packages.

@MakisH MakisH closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants