Skip to content

Minor fixes for load balancing and stateless simulations - #312

Merged
IshaanDesai merged 11 commits into
developfrom
small-fixes
Jul 26, 2026
Merged

Minor fixes for load balancing and stateless simulations #312
IshaanDesai merged 11 commits into
developfrom
small-fixes

Conversation

@Snapex2409

@Snapex2409 Snapex2409 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Load Balancing:

Added an implicit coupling iteration counter to determine the frequency of load balancing.

ModelManager:

Fixed the ModelWrapper for stateless simulations. Without the name property, it would return an incorrect class name during lookups.

Interpolation:

Fixed RBF basis functions. (brackets were placed incorrectly)
Fixed RBF interpolation domain selection. (mixed up tree height and depth)
Fixed interpolation normalization. Normalization scaling is now based on a fraction of the input and not constant.

Adaptivity:

Fixed data size extraction of micro simulation input and output during adaptivity interpolation for empty micro manager ranks.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • If this is a use-side change, I added a summary of the changes (compared to the last release) in the CHANGELOG.md. If this is a breaking change, I wrote breaking change at the end of the changelog entry.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge and provide a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai added the bug Something isn't working label Jul 23, 2026

@IshaanDesai IshaanDesai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add a changelog entry as these fixes affect users.

@Snapex2409
Snapex2409 marked this pull request as ready for review July 26, 2026 09:50
@IshaanDesai
IshaanDesai merged commit 448105a into develop Jul 26, 2026
11 checks passed
@IshaanDesai
IshaanDesai deleted the small-fixes branch July 26, 2026 18:18
@IshaanDesai IshaanDesai mentioned this pull request Aug 8, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants