Minor fixes for load balancing and stateless simulations - #312
Merged
Conversation
IshaanDesai
approved these changes
Jul 23, 2026
IshaanDesai
left a comment
Member
There was a problem hiding this comment.
Please don't forget to add a changelog entry as these fixes affect users.
Snapex2409
marked this pull request as ready for review
July 26, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load Balancing:
Added an implicit coupling iteration counter to determine the frequency of load balancing.
ModelManager:
Fixed the
ModelWrapperfor stateless simulations. Without the name property, it would return an incorrect class name during lookups.Interpolation:
Fixed RBF basis functions. (brackets were placed incorrectly)
Fixed RBF interpolation domain selection. (mixed up tree height and depth)
Fixed interpolation normalization. Normalization scaling is now based on a fraction of the input and not constant.
Adaptivity:
Fixed data size extraction of micro simulation input and output during adaptivity interpolation for empty micro manager ranks.
Checklist:
CHANGELOG.md. If this is a breaking change, I wrote breaking change at the end of the changelog entry.