Normalize generated preCICE data names - #320
Open
alloutflo wants to merge 1 commit into
Open
Conversation
alloutflo
marked this pull request as ready for review
August 11, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rank_of_simtoRank-Of-Simmodel_resolutiontoModel-ResolutionFixes #317
Root cause
The two optional outputs were registered in the Micro Manager configuration and emitted at runtime under snake_case names, while the other generated preCICE data names use the documented title-case, hyphenated convention. Changing only one side would make the configured write-data name disagree with the actual output dictionary, so this updates both paths together.
Validation
python -m unittest test_micro_manager.py test_model_adaptivity.py test_load_balancing.py— 18 tests passed, 6 parallel-only tests skipped in the serial runmpiexec -n 2 python -m unittest test_load_balancing.py— passed on both ranksmpiexec -n 4 --oversubscribe python -m unittest test_load_balancing.py— passed on all four rankspre-commit run --all-files --verbose— all hooks passedgit diff --check— cleanChecklist:
CHANGELOG.md. If this is a breaking change, I wrote breaking change at the end of the changelog entry.