Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent .gitignore among cases #87

Open
MakisH opened this issue Jun 29, 2020 · 2 comments
Open

Inconsistent .gitignore among cases #87

MakisH opened this issue Jun 29, 2020 · 2 comments
Assignees

Comments

@MakisH
Copy link
Member

MakisH commented Jun 29, 2020

In most cases, we don't have a .gitignore file, assuming that a developer would clean the result files (e.g. using Allclean) before commiting.

In other cases (e.g. tutorials/FSI/flap_perp/OpenFOAM-FEniCS/), we provide a .gitignore. In this specific case, the .gitignore is ignoring the complete case directories and then un-ignores specific files.

This inconsistency can lead in overseeing files when applying the same change in every tutorial.

A nice approach would be to have a global tutorials/.gitignore for the usual suspects (e.g. preCICE log files) and each tutorial could provide its own .gitignore for any special files.

@MakisH
Copy link
Member Author

MakisH commented Jul 21, 2020

Suggestion (@fsimonis):

  • Remove all the .gitignore files we have in case directories
  • Create a global .gitignore to ignore common file formats (e.g. .log)
  • In local .gitignore files exclude specific files.

@MakisH
Copy link
Member Author

MakisH commented Jan 25, 2022

Update on the state: we currently have no global .gitignore file, but we do have a local .gitignore in some cases. Find files in the repository pressing t on the GitHub page of the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants