-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure quickstart #145
Conversation
Ready for review, but still in draft in order to avoid an accidental merge. |
ab358ca
to
a88fce0
Compare
Please remember to not merge this before everything else is merged. Otherwise we change the content here: https://www.precice.org/quickstart.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, mostly very picky changes in the formulations and a rather important bug prevention in the scripts.
I ran the case and I observed that:
- ✔️ The case is running
- ❌ The
removeObsoleteFolders.sh
needs to remove thecd Fluid
and thecd ..
. - ✔️ The
plotDisplacement.sh
works - ✔️ ParaView works.
- ❔ I still see a kind-of "explosion" in the second half of the simulation (higher-frequency oscillation). Maybe we could add a note that this is expected and why.
- ❌
clean.sh
needs a few fixes (see review)
Looks very nice already! 🚀
Co-authored-by: Gerasimos Chourdakis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor changes in the README.md (sorry, I only saw them now)
Co-authored-by: Gerasimos Chourdakis <[email protected]>
…tutorials into restructure-quickstart
I added now a result figure. Feel free to comment on it. Other than that, the PR should be ready. |
Just a reminder |
@MakisH merging |
I looked at the commit with the cleaning/running and the latest state and it looks good 👍. |
Open TODOs: