Skip to content

Conversation

@MakisH
Copy link
Member

@MakisH MakisH commented Apr 11, 2021

This moves the fluid-fluid coupling tutorials from the OpenFOAM adapter.

Reviewers:

  • @uekerman please have a look at the README. I used the same precice-config.xml as with the previous 2xpimpleFoam (the compressible one was using parallel-implicit and had more relaxed convergence measures).

Before merging:

After merging:

@MakisH MakisH requested a review from uekerman April 11, 2021 21:52
@MakisH MakisH self-assigned this Apr 11, 2021
Base automatically changed from runscripts to develop April 12, 2021 05:37
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README looks good. Only minor things below.
You added four pngs for the pipe. On purpose?

@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2021

You added four pngs for the pipe. On purpose?

Yes, to showcase that all these combinations work. Would there be a reason to remove them? (details, but let's decide)

@uekerman
Copy link
Member

Yes, to showcase that all these combinations work. Would there be a reason to remove them? (details, but let's decide)

If we don't show them somewhere, we might forget why we have them.

@MakisH
Copy link
Member Author

MakisH commented Apr 12, 2021

Yes, to showcase that all these combinations work. Would there be a reason to remove them? (details, but let's decide)

If we don't show them somewhere, we might forget why we have them.

Good point, I removed them.

@MakisH MakisH merged commit efbfcfe into develop Apr 12, 2021
@MakisH MakisH deleted the pipe-pipe branch April 12, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants