Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity in openfoam-remove-empty-dirs.sh #368

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Aug 16, 2023

At the moment, at the end of each OpenFOAM simulation, one gets a long list of deleted directories. This is not only confusing, but it also makes the log less readable (as we often just look at the tail). In the system tests, we want to include only the tail of the logs in the GitHub Actions screen output, which means we need to make the tail more useful.

This PR:

  • Removes the -v option from the rm command when removing such empty dirs
  • Moves the "see OpenFOAM adapter issue" in a comment, with a proper URL, since this is something that users typically should not need to see. It is also strange seeing it all the time, it makes it more important than it is.
  • Adds a Done. message at the end.

@valentin-seitz maybe that would be something for you to quickly review. Do the changes make sense? How is the output now?

Copy link
Contributor

@valentin-seitz valentin-seitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is a bit less verbose, but everything is still cleaned up.

Looks good to me :)

@valentin-seitz valentin-seitz merged commit 9b4fba4 into develop Aug 16, 2023
@valentin-seitz valentin-seitz deleted the openfoam-cleanup-verbosity branch August 16, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants