-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkpointing and subcycling for solid.py
#475
Conversation
I see several changes here. Which one is the essence of the fix? Why was it broken before? Edit: I understand the issue was that the checkpoint was not complete, hence now
In the distribution, we need that all tutorials work with the respective versions of components released in the same distribution. So yes, please do that, if needed. |
Co-authored-by: Benjamin Rodenberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my limited viewpoint, this is ready to merge as soon as the corresponding FEniCS adapter feature is available.
@IshaanDesai please still review for the FEniCS-related details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I have only two minor comments.
Co-authored-by: Benjamin Rodenberg <[email protected]>
Fixes checkpointing by considering u, v, and a. Closes #50.
Note: This fix requires precice/fenics-adapter#170 which is currently not merged and also not released in v2.0.0 of fenics-adapter. Doing a 2.1.0 release of the adapter for this feature would not be a big problem from my perspective. Adding this fixed version of the tutorial to the distribution release gives us another example using subcycling + time interpolation.