-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up coded boundary conditions for OpenFOAM cases #501
Conversation
- both were only needed to account for the tools used to initialize the flow field, which were now repalced by coded parts
23145b9
to
9028805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the .gitignore
to add the generated dynamicCode
directory (but I guess we don't want to clean it, as we don't clean the solver codes as well).
I ran the partitioned-heat-conduction
case. I trust you have checked the turek-hron-fsi3
case.
changing the OpenFOAM version might lead to obscure errors, but we can still add something like this later on, if we find that it is important. |
Follow-up to #428
Cleans-up the run/clean scripts as we use coded boundary conditions and initial conditions since #428, i.e., tools such as
funkySetFields
andgroovyBC
are not required anymore. Also removes the0.orig
, as it is not needed anymore. Applies some formatting to the coded boundary conditions itself and applies the (promised) boundary condition correction in the `heatTransfer´ solver before entering the time loop.