Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up coded boundary conditions for OpenFOAM cases #501

Merged
merged 13 commits into from
Mar 26, 2024

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Mar 25, 2024

Follow-up to #428

Cleans-up the run/clean scripts as we use coded boundary conditions and initial conditions since #428, i.e., tools such as funkySetFields and groovyBC are not required anymore. Also removes the 0.orig, as it is not needed anymore. Applies some formatting to the coded boundary conditions itself and applies the (promised) boundary condition correction in the `heatTransfer´ solver before entering the time loop.

@davidscn davidscn requested a review from MakisH March 25, 2024 13:26
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the .gitignore to add the generated dynamicCode directory (but I guess we don't want to clean it, as we don't clean the solver codes as well).

I ran the partitioned-heat-conduction case. I trust you have checked the turek-hron-fsi3 case.

@davidscn
Copy link
Member Author

(but I guess we don't want to clean it, as we don't clean the solver codes as well)

changing the OpenFOAM version might lead to obscure errors, but we can still add something like this later on, if we find that it is important.

@davidscn davidscn merged commit d9e1db1 into develop Mar 26, 2024
1 check passed
@davidscn davidscn deleted the clean-up-codedBC branch March 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants