Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortran elastic-tube-1d solvers #606

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

YonatanGM
Copy link

@YonatanGM YonatanGM commented Jan 8, 2025

This PR adds Fortran solvers for elastic-tube-1d case using the Fortran bindings (not the Fortran module). I opened another PR #607 with the module approach if you prefer that

The solvers follow the same project structure as the other solvers. LAPACK is needed for the fluid solver (same as the C++ case). Run ./run.sh to compile and execute the solvers via CMake. The plotting scripts (plot-diameter.sh and plot-all.sh) are updated to show results for the Fortran case. The precommit yaml didnt have hooks for Fortran files, so I maunally formatted them using fprettify.

Results look consistent with the other solvers. I checked the VTK output, and the numbers match up to 5 decimal places on the last timestep. Also tested running the fortran case against the other solves and that seems to work fine too.

Results:
tutorials-elastic-tube-1d-all
Figure-fortran
Figure-python

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.
  • Update the image used in readme showing diameter and pressure of running all solvers against cpp to inlcude fortran case

@YonatanGM YonatanGM changed the title Add Fortran elastic-tube-1d solvers #576 Add Fortran elastic-tube-1d solvers Jan 8, 2025
@MakisH MakisH self-requested a review January 8, 2025 17:18
@MakisH MakisH self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants