Reorganize English strings#203
Open
prem-k-r wants to merge 2 commits into
Open
Conversation
prem-k-r
added
refactor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe English locale object ( ChangesLocale String Expansion — English
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 12 minutes and 50 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@locales/en.js`:
- Around line 190-191: Update the localized helper copy so it matches the
displayed label: change the value of minMaxTempSubText to reference "Feels" (the
actual UI label used by minMaxTempText) instead of "Feels Like". Locate the
minMaxTempText and minMaxTempSubText entries and make the subtext wording
consistent with the label.
- Line 258: Update the user-facing string for the localization key
"edgeThemeInfo" to correct the typo: replace "Goto Settings" with "Go to
Settings" so the value reads "Go to Settings > Appearance, then choose a color
that matches the extension theme."; locate the "edgeThemeInfo" entry in
locales/en.js and edit only the displayed text accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganized and expanded the English locale file (locales/en.js) into a comprehensive, sectioned structure for UI strings. The file is 266 lines and exports a single
enlocale object containing strings for the full application interface.Changes
Export/API changes
enlocale object; no public API or exported declarations were altered.Lines changed
Review effort