Skip to content

fix: smooth continuous second-hand motion with millisecond precision … #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfleper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: smooth continuous second-hand motion with millisecond precision … #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions scripts/clock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,21 +213,30 @@ async function initializeClock() {
function updateanalogclock() {
var currentTime = new Date();
var currentSeconds = currentTime.getSeconds();
var currentMilliseconds = currentTime.getMilliseconds();
var currentMinutes = currentTime.getMinutes();
var currentHours = currentTime.getHours();

// Calculate the new rotation values
let newSecondRotation = currentSeconds * 6; // 6° per second
let newSecondRotation = (currentSeconds + (currentMilliseconds / 1000)) * 6; // 6° per second with millisecond precision
let newMinuteRotation = currentMinutes * 6 + (currentSeconds / 10); // 6° per minute + adjustment for seconds
let newHourRotation = (30 * (currentHours % 12) + currentMinutes / 2); // 30° per hour + adjustment for minutes, 12-hour cycle

// Define reset conditions
const secondReset = currentSeconds === 0;
const minuteReset = currentMinutes === 0 && currentSeconds === 0;
const hourReset = currentHours % 12 === 0 && currentMinutes === 0 && currentSeconds === 0;

// Update each hand using the helper function
cumulativeSecondRotation = updateHandRotation("second", newSecondRotation, cumulativeSecondRotation, secondReset);
// Update second hand continuously while preserving forward motion across minute boundaries
const currentSecondTurn = Math.floor(cumulativeSecondRotation / 360) * 360;
let continuousSecondRotation = currentSecondTurn + newSecondRotation;
if (!isFirstLoad && continuousSecondRotation < cumulativeSecondRotation)
continuousSecondRotation += 360;

cumulativeSecondRotation = continuousSecondRotation;
document.getElementById("second").style.transition = "transform 0.05s linear";
document.getElementById("second").style.transform = `rotate(${cumulativeSecondRotation}deg)`;

// Keep existing smooth behavior for minute and hour hands
cumulativeMinuteRotation = updateHandRotation("minute", newMinuteRotation, cumulativeMinuteRotation, minuteReset);
cumulativeHourRotation = updateHandRotation("hour", newHourRotation, cumulativeHourRotation, hourReset);

Expand Down Expand Up @@ -407,7 +416,7 @@ async function initializeClock() {
// Function to start the analog clock
function startAnalogClock() {
if (!analogIntervalId) { // Only set interval if not already set
analogIntervalId = setInterval(updateanalogclock, 500);
analogIntervalId = setInterval(updateanalogclock, 50);
}
}

Expand Down Expand Up @@ -553,4 +562,4 @@ async function initializeClock() {
loadActiveStatus("timeformatField", timeformatField);
loadActiveStatus("greetingField", greetingField);
});
}
}