Skip to content

Commit

Permalink
fix: Filters badge disappeared (apache#32025)
Browse files Browse the repository at this point in the history
  • Loading branch information
kgabryje authored Jan 29, 2025
1 parent 19e8a70 commit a87a13c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,10 @@ export const FiltersBadge = ({ chartId }: FiltersBadgeProps) => {
setDashboardIndicators(indicatorsInitialState);
} else if (prevChartStatus !== 'success') {
if (
chart?.queriesResponse?.rejected_filters !==
prevChart?.queriesResponse?.rejected_filters ||
chart?.queriesResponse?.applied_filters !==
prevChart?.queriesResponse?.applied_filters ||
chart?.queriesResponse?.[0]?.rejected_filters !==
prevChart?.queriesResponse?.[0]?.rejected_filters ||
chart?.queriesResponse?.[0]?.applied_filters !==
prevChart?.queriesResponse?.[0]?.applied_filters ||
dashboardFilters !== prevDashboardFilters ||
datasources !== prevDatasources
) {
Expand Down Expand Up @@ -215,10 +215,10 @@ export const FiltersBadge = ({ chartId }: FiltersBadgeProps) => {
setNativeIndicators(indicatorsInitialState);
} else if (prevChartStatus !== 'success') {
if (
chart?.queriesResponse?.rejected_filters !==
prevChart?.queriesResponse?.rejected_filters ||
chart?.queriesResponse?.applied_filters !==
prevChart?.queriesResponse?.applied_filters ||
chart?.queriesResponse?.[0]?.rejected_filters !==
prevChart?.queriesResponse?.[0]?.rejected_filters ||
chart?.queriesResponse?.[0]?.applied_filters !==
prevChart?.queriesResponse?.[0]?.applied_filters ||
nativeFilters !== prevNativeFilters ||
chartLayoutItems !== prevChartLayoutItems ||
dataMask !== prevDataMask ||
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/explore/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export interface ChartState {
latestQueryFormData: Partial<QueryFormData>;
sliceFormData: QueryFormData | null;
queryController: AbortController | null;
queriesResponse: QueryData | null;
queriesResponse: QueryData[] | null;
triggerQuery: boolean;
}

Expand Down

0 comments on commit a87a13c

Please sign in to comment.