Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify code block syntax #24693

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Mar 9, 2025

Description

The PR specifies shell script syntax in the code blocks.

Motivation and Context

Better syntax highlighting and the ability to execute code from the IDE.

Impact

No

Test Plan

Compare how presto-docs/README.md rendered before and after changes.

Before - there are no launch buttons:
image

After - there are launch buttons:
image

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@dnskr dnskr requested review from steveburnett and a team as code owners March 9, 2025 15:08
@dnskr dnskr requested a review from jaystarshot March 9, 2025 15:08
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

@dnskr dnskr force-pushed the specify-code-block-syntax branch from 97ef6c9 to 5ab2619 Compare March 15, 2025 12:00
@steveburnett steveburnett merged commit 446afa2 into prestodb:master Mar 17, 2025
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants