Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConnectorDeleteTableHandle to ConnectorProtocol #24721

Merged
merged 2 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import static com.facebook.presto.execution.TaskStatus.initialTaskStatus;
import static com.facebook.presto.execution.buffer.BufferState.OPEN;
import static com.facebook.presto.metadata.MetadataUpdates.DEFAULT_METADATA_UPDATES;
import static com.facebook.presto.util.DateTimeUtils.toTimeStampInMillis;
import static com.google.common.base.MoreObjects.toStringHelper;
import static com.google.common.base.Preconditions.checkArgument;
import static java.lang.System.currentTimeMillis;
Expand All @@ -56,51 +55,30 @@ public class TaskInfo
private final MetadataUpdates metadataUpdates;
private final String nodeId;

public TaskInfo(TaskId taskId,
TaskStatus taskStatus,
long lastHeartbeatInMillis,
OutputBufferInfo outputBuffers,
Set<PlanNodeId> noMoreSplits,
TaskStats stats,
boolean needsPlan,
MetadataUpdates metadataUpdates,
String nodeId)
{
this.taskId = requireNonNull(taskId, "taskId is null");
this.taskStatus = requireNonNull(taskStatus, "taskStatus is null");
checkArgument(lastHeartbeatInMillis >= 0, "lastHeartbeat is negative");
this.lastHeartbeatInMillis = lastHeartbeatInMillis;
this.outputBuffers = requireNonNull(outputBuffers, "outputBuffers is null");
this.noMoreSplits = requireNonNull(noMoreSplits, "noMoreSplits is null");
this.stats = requireNonNull(stats, "stats is null");

this.needsPlan = needsPlan;
this.metadataUpdates = metadataUpdates;
this.nodeId = requireNonNull(nodeId, "nodeId is null");
}

@JsonCreator
@ThriftConstructor
public TaskInfo(
@JsonProperty("taskId") TaskId taskId,
@JsonProperty("taskStatus") TaskStatus taskStatus,
@JsonProperty("lastHeartbeat") DateTime lastHeartbeat,
@JsonProperty("lastHeartbeatInMillis") long lastHeartbeatInMillis,
@JsonProperty("outputBuffers") OutputBufferInfo outputBuffers,
@JsonProperty("noMoreSplits") Set<PlanNodeId> noMoreSplits,
@JsonProperty("stats") TaskStats stats,
@JsonProperty("needsPlan") boolean needsPlan,
@JsonProperty("metadataUpdates") MetadataUpdates metadataUpdates,
@JsonProperty("nodeId") String nodeId)
{
this(taskId,
taskStatus,
toTimeStampInMillis(lastHeartbeat),
outputBuffers,
noMoreSplits,
stats,
needsPlan,
metadataUpdates,
nodeId);
this.taskId = requireNonNull(taskId, "taskId is null");
this.taskStatus = requireNonNull(taskStatus, "taskStatus is null");
checkArgument(lastHeartbeatInMillis >= 0, "lastHeartbeat is negative");
this.lastHeartbeatInMillis = lastHeartbeatInMillis;
this.outputBuffers = requireNonNull(outputBuffers, "outputBuffers is null");
this.noMoreSplits = requireNonNull(noMoreSplits, "noMoreSplits is null");
this.stats = requireNonNull(stats, "stats is null");

this.needsPlan = needsPlan;
this.metadataUpdates = metadataUpdates;
this.nodeId = requireNonNull(nodeId, "nodeId is null");
}

@JsonProperty
Expand All @@ -117,13 +95,13 @@ public TaskStatus getTaskStatus()
return taskStatus;
}

@JsonProperty
@ThriftField(3)
public DateTime getLastHeartbeat()
{
return new DateTime(lastHeartbeatInMillis);
}

@JsonProperty
@ThriftField(3)
public long getLastHeartbeatInMillis()
{
return lastHeartbeatInMillis;
Expand Down
Loading
Loading