Decompile overlay 44#478
Conversation
…rdle/pokeheartgold into decomp/overlay_44_02232E9C
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
Mostly nitpicks, don't forget to also run format.sh
| } | ||
|
|
||
| s32 ov44_0222EA2C(UnkStruct_ov44_022319EC* arg0, s32 arg1) { | ||
| ListMenuTemplate spC; // Unknown struct of size 0x20 |
There was a problem hiding this comment.
can remove comment
There was a problem hiding this comment.
I used ListMenuTemplate as a placeholder type that fit the size, still unknown what type sub_0203A1C4 actually expects
| GfGfx_EngineBTogglePlanes(8, 1); | ||
| } | ||
|
|
||
| void ov44_02230300(UnkStruct_ov44_022319EC* arg0, enum HeapID heapID) { |
There was a problem hiding this comment.
It's clear that this and the below functions print records messages, but I'm not sure off the top of my head where this would be in the game. Could be a good clue to start documenting the file as a whole though. Maybe in some multiplayer setting?
adrienntindall
left a comment
adrienntindall
left a comment
There was a problem hiding this comment.
There's still some documentation work I see that can be done but this PR is big enough already that it can be handled at a later date when someone wants to go through and document everything properly
2 participants
Wasn't able to get most of the data to match because of ordering, so left them in overlay_44.s but included comments in the C files with the decompiled data.