-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify various flag labels and bit constants #454
Conversation
Some notes on naming choices:
|
f7fa11f
to
c62b399
Compare
@dannye @vulcandth I think all that really needs reviewing are the constants and wram files; the rest are just many uses of those new constants+labels. |
@dannye Okay, this is ready. I'm open to changing some of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
@dannye Thank you for your review comments! They should all now be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is pretty great, thanks for doing it.
(cherry picked from commit 8fafca7)
+ conflict resolution
After this, only four labels will be unidentified:
wcd6d
(110 uses)wcf91
(171 uses)wd0b5
(56 uses)wd11e
(163 uses)Of course, there are still many non-label constants left to be identified. In particular, flag bits and meaningful RAM values that should be going in the new ram_constants.asm file.