Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem #457

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jul 24, 2024

wcf91 corresponds to these bytes in pokegold:

wCurItem:: db
wCurItemQuantity::
wMartItemID::
	db

wCurPartySpecies:: db

(Note the labels after it, e.g. pokered wWhichPokemon corresponds to pokegold wCurPartyMon, wHPBarType to wWhichHPBar, wRemoveMonFromBox to wPokemonWithdrawDepositParameter, etc.)

Unlike in pokegold, the species ID and item ID share a byte. This is important for DisplayListMenuID and probably elsewhere.

@Rangi42 Rangi42 requested a review from dannye July 24, 2024 17:52
@Rangi42
Copy link
Member Author

Rangi42 commented Jul 24, 2024

The ideal way to test that this PR is accurate would be to split the labels into separate bytes, manually add copying in any places which rely on them to be identical (AFAIK only in DisplayListMenuID, which has asserts to that effect), and then play the game. But that's a lot of trouble. :P

Edit: Playing up to Vermilion City, doing stuff like checking the Pokedex, teaching TMs, evolving Pokemon, trade evolutions, etc, behaves just fine when I split them up. So @dannye I'm confident this label splitting is accurate. :)

@Rangi42 Rangi42 requested a review from vulcandth July 24, 2024 20:22
@Rangi42 Rangi42 merged commit 77d0514 into pret:master Aug 4, 2024
1 check passed
@Rangi42 Rangi42 deleted the wcf91 branch August 4, 2024 14:05
PokefanMarcel pushed a commit to PokefanMarcel/yumepokered that referenced this pull request Oct 18, 2024
PokefanMarcel added a commit to PokefanMarcel/yumepokered that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant