Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node #96

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Remove node #96

merged 1 commit into from
Aug 6, 2015

Conversation

stefanpenner
Copy link
Contributor

this depends on: #95

relevant commit: 71dbac0

Why?:

  • the current code does not support node, it uses window/self all over the place
  • the current node detection breaks in NW.js environments
  • the code isn't tested on node
  • node doesn't have global.XMLHTTPRequest

@trek this may be controversial so I would like your +1

@mike-north
Copy link
Member

rebase please

@stefanpenner
Copy link
Contributor Author

rebased – pending @trek's feedback on next steps.

@stefanpenner
Copy link
Contributor Author

@trek wants me to ensure browserify works correctly, then we can 🚢.

@stefanpenner stefanpenner force-pushed the remove-node branch 4 times, most recently from 850b704 to 1626659 Compare August 6, 2015 20:17
@mike-north
Copy link
Member

LGTM

@trek
Copy link
Member

trek commented Aug 6, 2015

I'm +1

trek added a commit that referenced this pull request Aug 6, 2015
@trek trek merged commit 977e707 into master Aug 6, 2015
@trek trek deleted the remove-node branch August 6, 2015 20:24
xcambar added a commit to xcambar/pretender that referenced this pull request Jan 21, 2016
@taras
Copy link

taras commented Mar 25, 2017

@stefanpenner @trek would you guys be open to a proper implementation of node support? #192

I've been busy with a project but I'm finished now. Hoping to find some time to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants