-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node #96
Merged
Merged
Remove node #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase please |
71dbac0
to
1f3c174
Compare
rebased – pending @trek's feedback on next steps. |
@trek wants me to ensure browserify works correctly, then we can 🚢. |
850b704
to
1626659
Compare
1626659
to
7ff00f1
Compare
LGTM |
I'm +1 |
xcambar
added a commit
to xcambar/pretender
that referenced
this pull request
Jan 21, 2016
@stefanpenner @trek would you guys be open to a proper implementation of node support? #192 I've been busy with a project but I'm finished now. Hoping to find some time to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this depends on: #95
relevant commit: 71dbac0
Why?:
global.XMLHTTPRequest
@trek this may be controversial so I would like your +1