-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: 정산 뷰 수정 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KEEKE132
merged 12 commits into
feat/28-Budget_view
from
refactor/56-settlement-integration
May 20, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
354ade3
fix: id.string bug
KEEKE132 f6afafd
refactor: settlementResponse 응답에 연관이름 추가
KEEKE132 b777cc3
fix: 경로 수정
KEEKE132 8780564
fix: 상세 페이지 수정
KEEKE132 ac0f10c
fix: 정산 목록페이지 수정
KEEKE132 4afffaf
fix: 정산 폼 수정
KEEKE132 f11f4d1
fix: updateSettlement
KEEKE132 8db73f6
fix: edit page, list page
KEEKE132 0ef2074
fix: init pagination metadata
KEEKE132 99c9339
fix: init pagination metadata
KEEKE132 1473788
refactor: use recoilTeamId
KEEKE132 2ce7ad7
Merge remote-tracking branch 'origin/feat/28-Budget_view' into refact…
KEEKE132 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 15 additions & 13 deletions
28
Frontend/luckeyseven/src/components/common/UserProfile.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,19 @@ | ||
| export function UserProfile({ user, label }) { | ||
| export function UserProfile({nickname, label}) { | ||
| return ( | ||
| <div> | ||
| <p className="text-sm text-muted">{label}</p> | ||
| <div className="flex items-center mt-1 space-x-2"> | ||
| {user?.avatar ? ( | ||
| <img src={user.avatar || "/placeholder.svg"} alt={user.name} className="w-8 h-8 rounded-full" /> | ||
| ) : ( | ||
| <div className="w-8 h-8 rounded-full bg-gray-200 flex items-center justify-center"> | ||
| {user?.name.charAt(0) || "?"} | ||
| </div> | ||
| )} | ||
| <span className="font-medium">{user?.name || "알 수 없음"}</span> | ||
| <div> | ||
| <p className="text-sm text-muted">{label}</p> | ||
| <div className="flex items-center mt-1 space-x-2"> | ||
| {nickname ? ( | ||
| <img src={"/placeholder.svg"} alt={nickname} | ||
| className="w-8 h-8 rounded-full"/> | ||
| ) : ( | ||
| <div | ||
| className="w-8 h-8 rounded-full bg-gray-200 flex items-center justify-center"> | ||
| {nickname.charAt(0) || "?"} | ||
| </div> | ||
| )} | ||
| <span className="font-medium">{nickname || "알 수 없음"}</span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure 'nickname' is defined before calling charAt(0) in the fallback rendering to avoid potential runtime errors. Use a conditional check or default value.