Skip to content

Update to Tailwind v4#84

Open
antoniomacri wants to merge 5 commits into
primefaces:masterfrom
antoniomacri:master
Open

Update to Tailwind v4#84
antoniomacri wants to merge 5 commits into
primefaces:masterfrom
antoniomacri:master

Conversation

@antoniomacri
Copy link
Copy Markdown

@antoniomacri antoniomacri commented May 20, 2025

Solves #71

Antonio Macrì added 4 commits May 20, 2025 23:26
@imaa
Copy link
Copy Markdown

imaa commented Jun 4, 2025

youre PR is not mature, configurator does not close, side menu icons not the same as before, login,notfound, error not same design

@OnurEAkgul
Copy link
Copy Markdown

I've tried the same steps as you, using .postcssrc.json etc. etc. and encountered the same issues that @imaa said. the configurator not closing, login screen's broken css and the other pages

@antoniomacri
Copy link
Copy Markdown
Author

You're right, I also noticed the problem on the configurator. However, I'm currently having no time to look at it, any help is appreciated.

Comment thread src/tailwind.css
Co-authored-by: Ingmar Jager <ijager@users.noreply.github.com>
@antoniomacri
Copy link
Copy Markdown
Author

I noticed the original sakai theme also has some glitches. For instance in dark mode some numbers remain with the light theme and therefore are not visible:

Screenshot 2025-07-15 alle 22 13 53

(there should be a "152" under Orders).

@OnurEAkgul
Copy link
Copy Markdown

OnurEAkgul commented Jul 16, 2025

have you tested the dark mode compatibility? because in the dark mode everything seems to be working but when using the light mode the floating configurator stays in the dark mode. such as the pages like auth login error and not found, theese are the problems i just found, at least the styling has now been fixed and floating config is now can be closed

@imaa
Copy link
Copy Markdown

imaa commented Jul 17, 2025

it looks good now Thanks
image

@gentunian
Copy link
Copy Markdown

have you tested the dark mode compatibility? because in the dark mode everything seems to be working but when using the light mode the floating configurator stays in the dark mode. such as the pages like auth login error and not found, theese are the problems i just found, at least the styling has now been fixed and floating config is now can be closed

I've found based on docs and how the app uses the .app-dark selector it's required for you to add it manually:

// tailwind.css file
@custom-variant dark (&:where(.app-dark, .app-dark *));

I'll add the suggestion to this PR to be added.

Comment thread src/tailwind.css
@tailwind base;
@tailwind components;
@tailwind utilities;
@import 'tailwindcss';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@import 'tailwindcss';
@import 'tailwindcss';
@plugin "tailwindcss-primeui";
@custom-variant dark (&:where(.app-dark, .app-dark *));

Based on tailwind v4 you may need this: https://tailwindcss.com/docs/dark-mode#toggling-dark-mode-manually

PS: tried to add a suggestion without luck

@antoniomacri
Copy link
Copy Markdown
Author

We are being totally ignored here...

I've noticed there is similar work being done in the v20 branch. @mehmetcetin01140 what do we do here with the PR and the related issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants