Skip to content

SelectPanel: Add example of inactiveText usage #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented May 28, 2025

Context: https://github.com/github/primer/issues/5220

Adds example of inactiveText usage in SelectPanel

Changelog

Changed

  • Adds example of inactive usage in SelectPanel

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented May 28, 2025

⚠️ No Changeset found

Latest commit: 154262a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 28, 2025
Copy link
Contributor

github-actions bot commented May 28, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.51 KB (0%)
packages/react/dist/browser.umd.js 94.64 KB (0%)

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Jun 2, 2025
@TylerJDev TylerJDev marked this pull request as ready for review June 2, 2025 17:57
@Copilot Copilot AI review requested due to automatic review settings June 2, 2025 17:57
@TylerJDev TylerJDev requested a review from a team as a code owner June 2, 2025 17:57
@TylerJDev TylerJDev requested a review from joshblack June 2, 2025 17:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Storybook example demonstrating how to use the inactiveText prop in SelectPanel.

  • Introduces a new Items type with an optional inactiveText field
  • Creates itemsWithInactive, an array extending the base items to include one inactive item
  • Adds the WithInactiveItems story to showcase the inactiveText usage
Comments suppressed due to low confidence (2)

packages/react/src/SelectPanel/SelectPanel.features.stories.tsx:809

  • [nitpick] The type name Items is plural and generic. Consider renaming it to a singular, descriptive name like SelectPanelItemWithInactiveText to more clearly convey its purpose.
type Items = ItemInput & {

packages/react/src/SelectPanel/SelectPanel.features.stories.tsx:819

  • There are no existing tests covering the new inactiveText prop. Consider adding unit or integration tests to verify that this text is rendered correctly in SelectPanel when items are inactive.
inactiveText: 'Currently inactive due to an outage',

@TylerJDev TylerJDev added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit 40c63e5 Jun 2, 2025
39 of 40 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/selectpanel-inactive branch June 2, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants