Add vscode task for test-e2e
#6337
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds VS Code tasks to run end-to-end tests with Docker management functionality. It replaces the existing "Generate e2e tests" task with two new tasks that can run e2e tests either for all components or for a specific component.
- Adds Docker detection and automatic startup functionality
- Creates two new tasks: one for running all e2e tests and another for running tests on a specific component
- Includes input prompts for component selection when running specific tests
.vscode/tasks.json
Outdated
| "type": "shell", | ||
| "args": [ | ||
| "script/generate-e2e-tests.js" | ||
| "-c", | ||
| "if ! docker --version >/dev/null 2>&1; then echo \"Docker is required for this script to run. Install Docker Desktop from https://www.docker.com/products/docker-desktop/\"; exit 1; elif ! docker info >/dev/null 2>&1; then echo \"Docker installed but not running. Starting Docker Desktop...\"; open -a Docker && echo \"Waiting for Docker to start...\" && while ! docker info >/dev/null 2>&1; do sleep 2; done && echo \"Docker is now running\"; fi; ./script/test-e2e" |
There was a problem hiding this comment.
This one-liner bash script is extremely difficult to read and maintain. Consider extracting this logic into a separate shell script file (e.g., script/run-e2e-with-docker.sh) and calling that script instead.
Copilot uses AI. Check for mistakes.
| "type": "shell", | ||
| "args": [ | ||
| "-c", | ||
| "COMPONENT=\"${input:componentName}\"; if [[ \"$COMPONENT\" == *.test.ts ]]; then TEST_FILE=\"$COMPONENT\"; else TEST_FILE=\"e2e/components/$COMPONENT.test.ts\"; fi; if ! docker --version >/dev/null 2>&1; then echo \"Docker is required for this script to run. Install Docker Desktop from https://www.docker.com/products/docker-desktop/\"; exit 1; elif ! docker info >/dev/null 2>&1; then echo \"Docker installed but not running. Starting Docker Desktop...\"; open -a Docker && echo \"Waiting for Docker to start...\" && while ! docker info >/dev/null 2>&1; do sleep 2; done && echo \"Docker is now running\"; fi; ./script/test-e2e \"$TEST_FILE\"" |
There was a problem hiding this comment.
This one-liner contains duplicated Docker management logic and is extremely difficult to read and maintain. The Docker checking logic is repeated from the previous task. Consider extracting both the Docker management and component resolution logic into separate shell scripts.
Copilot uses AI. Check for mistakes.
| "type": "shell", | ||
| "args": [ | ||
| "-c", | ||
| "COMPONENT=\"${input:componentName}\"; if [[ \"$COMPONENT\" == *.test.ts ]]; then TEST_FILE=\"$COMPONENT\"; else TEST_FILE=\"e2e/components/$COMPONENT.test.ts\"; fi; if ! docker --version >/dev/null 2>&1; then echo \"Docker is required for this script to run. Install Docker Desktop from https://www.docker.com/products/docker-desktop/\"; exit 1; elif ! docker info >/dev/null 2>&1; then echo \"Docker installed but not running. Starting Docker Desktop...\"; open -a Docker && echo \"Waiting for Docker to start...\" && while ! docker info >/dev/null 2>&1; do sleep 2; done && echo \"Docker is now running\"; fi; ./script/test-e2e \"$TEST_FILE\"" |
There was a problem hiding this comment.
The open -a Docker command is macOS-specific and will fail on Windows or Linux systems. Consider adding platform detection or documenting that this task only works on macOS.
| "COMPONENT=\"${input:componentName}\"; if [[ \"$COMPONENT\" == *.test.ts ]]; then TEST_FILE=\"$COMPONENT\"; else TEST_FILE=\"e2e/components/$COMPONENT.test.ts\"; fi; if ! docker --version >/dev/null 2>&1; then echo \"Docker is required for this script to run. Install Docker Desktop from https://www.docker.com/products/docker-desktop/\"; exit 1; elif ! docker info >/dev/null 2>&1; then echo \"Docker installed but not running. Starting Docker Desktop...\"; open -a Docker && echo \"Waiting for Docker to start...\" && while ! docker info >/dev/null 2>&1; do sleep 2; done && echo \"Docker is now running\"; fi; ./script/test-e2e \"$TEST_FILE\"" | |
| "COMPONENT=\"${input:componentName}\"; if [[ \"$COMPONENT\" == *.test.ts ]]; then TEST_FILE=\"$COMPONENT\"; else TEST_FILE=\"e2e/components/$COMPONENT.test.ts\"; fi; if ! docker --version >/dev/null 2>&1; then echo \"Docker is required for this script to run. Install Docker Desktop from https://www.docker.com/products/docker-desktop/\"; exit 1; elif ! docker info >/dev/null 2>&1; then echo \"Docker installed but not running.\"; if [[ $(uname) == \"Darwin\" ]]; then echo \"Starting Docker Desktop on macOS...\"; open -a Docker && echo \"Waiting for Docker to start...\" && while ! docker info >/dev/null 2>&1; do sleep 2; done && echo \"Docker is now running\"; else echo \"Please start Docker manually on your platform.\"; exit 1; fi; fi; ./script/test-e2e \"$TEST_FILE\"" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Someone tell me if this is a good suggestion.. copilot suggesting changes to its own code, so fun 😄
| }, | ||
| ], |
There was a problem hiding this comment.
There is a trailing comma after the tasks array which is not valid JSON syntax.
| }, | |
| ], | |
| } | |
| ] |
Copilot uses AI. Check for mistakes.
size-limit report 📦
|
Adds a vscode task to run
test-e2e.