fix: compute source map relative paths according to srcDir
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, a source map for a file available under `dist/index.js`
would indicate the source file to be relatively available at
`../../src/index.ts` where it is actually relatively available at
`../src/index.ts`
This change comes with the side-effect of enforcing type exports to be
declared as such (`export type {} from ""`) because they are not checked
lihbr
changed the title
srcDir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Without this change, a source map for a file available under
dist/index.jswould indicate the source file to be relatively available at../../src/index.tswhere it is actually relatively available at../src/index.tsThis change comes with the side-effect of enforcing type exports to be declared as such (
export type {} from "") because they are not checked.Unrelated: maintained dependencies & update license
Checklist:
🦃