update!: Add LTeX for VS Code and remove LanguageTool #3031
Conversation
|
This pull request has been mentioned on Privacy Guides Community. There might be relevant details there: https://discuss.privacyguides.net/t/remove-languagetool-other-than-self-hosting/26683/8 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation to remove LanguageTool references and add LTeX for VS Code as the recommended self-hosted grammar and spell checking solution.
- Removed LanguageTool logo and related links from tools documentation
- Updated language tools page to feature LTeX for VS Code with new descriptions and links
- Adjusted criteria to emphasize complete offline operation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/tools.md | Replaced LanguageTool card with LTeX for VS Code |
| docs/language-tools.md | Updated header, logo, description, and links for LTeX |
✅ Your preview is ready!
|
redoomed1
added
the
c:software
github-project-automation
bot
moved this from Unreviewed
to Has Approval
in PR Review Status
friadev
left a comment
friadev
left a comment
There was a problem hiding this comment.
Discussion not approved, I think there should be a separate discussion for LTeX.
github-project-automation
bot
moved this from Has Approval
to Needs Changes
in PR Review Status
|
This pull request has been mentioned on Privacy Guides Community. There might be relevant details there: https://discuss.privacyguides.net/t/ltex-spelling-grammar-check/27547/1 |
|
Maybe we should also split the PRs between adding LTeX and removing LanguageTool, no reason for one to hold up the other. |
|
I don't think this will really hold anything up, since it is the same tool simply packaged differently. |
github-project-automation
bot
moved this from Needs Changes
to Done
in PR Review Status
redoomed1
left a comment
redoomed1
left a comment
There was a problem hiding this comment.
I think @ph00lt0 [1] and AtomicBug [2] raise a good point that recommending a VS Code extension alone would be odd for the website's target audience. Instead, the changes I suggest below foregrounds LTeX the software, and mentions the options for how to use it (CLI, code editor extension) in the description.
github-project-automation
bot
moved this from Unreviewed
to Needs Changes
in PR Review Status
|
I’m just not really understanding why we are adding LTeX in the same PR, they should be separate, especially since it’s not approved on the forum and several team members are against it. Bundling uncontroversial changes with ones that haven’t been properly discussed yet causes important changes to get delayed for months. |
There was a problem hiding this comment.
As @friadev pointed out, discussion and review is lacking of LTeX and i besides not fitting audience of the website as @redoomed1 also seconds we have not reviewed the project properly.
List of changes proposed in this PR:
Remove LanguageTool: FORUM-26683
Add LTeX for VSCode
This is a LanguageTool-based extension that defaults to downloading and running a fully self-hosted version of LanguageTool completely offline. It is also the only fully self-hosted install of LanguageTool that I have personally tested, and we use it already in our default VSCode config:
privacyguides.org/.vscode/extensions.json
Line 30 in b2251c7
I'm not suggesting this is a full LanguageTool replacement in itself, but I am suggesting that we add more recommendations similar to this one (ones that bundle LanguageTool self-hosted) in future PRs, instead of blanket recommending LanguageTool itself, due to concerns with the cloud version of LT. So this PR is just a starting point.