Add all supported versions of php to github workflow (8.1, 8.2, 8.3) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To note, I did run the tests locally in 8.1, 8.2, and 8.3 all passing fine. |
OskarStark
approved these changes
Oct 7, 2024
OskarStark
reviewed
Jan 2, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "probots-io/pinecone-php", | |||
| "name": "scotteuser/pinecone-php", | |||
Contributor
Author
|
Very sorry about that; shouldn't have made the PR from master branch in my fork as ultimately we needed to unblock dependencies to stay compatible with supported Drupal versions. I could not see how to change source branch in the PR so I created a new one: #17 - apologies for the extra noise/extra work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this excellent project. We have started using it in https://www.drupal.org/project/ai and will contribute back where we can. We would like to keep the module as compatible as possible with the range of PHP versions Drupal supports (https://www.drupal.org/docs/getting-started/system-requirements/php-requirements) which matches the wider PHP versions supported (https://www.php.net/supported-versions.php).
Tests currently support only PHP 8.2. This PR changes the github workflow to test 8.1, 8.2, and 8.3 + changes the composer.json to have a minimum version of PHP 8.1 (which is also what saloonphp/saloon requires).
Thank you!