-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Placeholder link style contrast refactor #4319
Copy link
Copy link
Open
Labels
Area: DesignFor UI/UX design updates, proposals, or feedbackFor UI/UX design updates, proposals, or feedbackArea:AccessibilityCategory for accessibility related features and bugsCategory for accessibility related features and bugsArea:CSSFor styling or layout issues handled with CSS/SASSFor styling or layout issues handled with CSS/SASSArea:EditorFor CodeMirror-related featuresFor CodeMirror-related featuresEnhancementImprovement to an existing featureImprovement to an existing featureGood First IssueA beginner-friendly issue, great for first-time contributorsA beginner-friendly issue, great for first-time contributors
Description
Activity
Metadata
Metadata
Assignees
Labels
Area: DesignFor UI/UX design updates, proposals, or feedbackFor UI/UX design updates, proposals, or feedbackArea:AccessibilityCategory for accessibility related features and bugsCategory for accessibility related features and bugsArea:CSSFor styling or layout issues handled with CSS/SASSFor styling or layout issues handled with CSS/SASSArea:EditorFor CodeMirror-related featuresFor CodeMirror-related featuresEnhancementImprovement to an existing featureImprovement to an existing featureGood First IssueA beginner-friendly issue, great for first-time contributorsA beginner-friendly issue, great for first-time contributors
Increasing Access
This feature would ensure that links without specified styles will by default have high enough contrast with the main background colors of each theme.
Feature enhancement details
Links in the console area of the editor use the placeholder link color, which is
inactive-text-colorat rest andheavy-text-coloron hover.This makes the links far too low contrast in the light theme (1.9:1 ratio):
Using

heavy-text-colorat rest would give a 15:1 contrast ratio:My proposed fix is to change the placeholder link styling to
heavy-text-colorby default. The link should also have an underline by default that becomes thicker on hover (like the change in #3560 ). The thickness should be 0.1em.Changing the links in dark and high contrast mode to
heavy-text-colorwould also increase the contrast (though the contrast is ok as is), so this change would not decrease accessibility.Changes:
inactive-text-color' toheavy-text-color`text-decoration: nonetotext-decoration: underlinefor the default link statetext-decoration-thickness: 0.1em;to the hover state.