Skip to content

by default theme will be system's theme #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rohanjadhav05
Copy link
Contributor

@rohanjadhav05 rohanjadhav05 commented Jun 14, 2024

Fixes #3061

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim added Area:Accessibility Category for accessibility related features and bugs Enhancement labels Jun 14, 2024
@raclim
Copy link
Collaborator

raclim commented Jul 3, 2024

Thanks for your work on this! I think while this would work, I would like to find a solution that utilizes the suggested method in the issue, which is using the CSS media feature, prefers-color-scheme. Due to the amount of PRs we have open at the moment I'm going to close this one for now. I'm sorry that we couldn't get this one in, but please feel free to reopen this one with any updates or check out our other issues!

@raclim raclim closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply user's system color-scheme preference as the default site theme
2 participants