Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance hover effect on console Clear button #2592 #3397

Merged

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Mar 15, 2025

Fixes #2592

Changes:

  1. Updated the colour of the hover effect for the Clear button in the console in _console.scss file.
  2. The colour is mentioned in the theme file for all the 3 (Light , Dark and High contrast themes).

For Light Mode :
Light mode

For Dark Mode :
Dark mode

For High-Contrast Mode :
High-Contrast Mode

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@Harshit-7373
Copy link
Contributor Author

@raclim , it was discussed in the comment section of the issue that changing only the text color is the best option.

If you want, I can add a smooth transition similar to how it works for different features in the p5.js web editor. Please share your thoughts on this.

@raclim raclim added Area:CSS Area:Accessibility Category for accessibility related features and bugs labels Mar 17, 2025
@Harshit-7373
Copy link
Contributor Author

@raclim I have updated the requested Changes. Please Check them once.

Screenshot 2025-03-18 at 1 38 56 AM Here is an image , That shows that the required changes are shown correctly.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! After looking a bit more closely, I think it might be best to add a few changes, which I made note of. Let me know if you have any questions about them!

@Harshit-7373
Copy link
Contributor Author

@raclim I have Corrected and Updated the file taking reference of the requested changes.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! I made a few extra adjustments to the formatting to ensure minimal changes, so I think this is good to go.

@raclim raclim merged commit a51d0bf into processing:develop Mar 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Area:CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient hover effect on console Clear button
2 participants