Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color issue on hover for sketch name by username #2676 #3408

Closed
wants to merge 1 commit into from
Closed

Fix background color issue on hover for sketch name by username #2676 #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions client/modules/IDE/components/Header/Toolbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const Toolbar = (props) => {
</button>
<button
className={playButtonClass}
id="play-sketch"
Copy link
Contributor

@Jatin24062005 Jatin24062005 Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you removed this???

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the context of this PR, I think this should not be removed!

onClick={() => {
props.syncFileContent();
dispatch(startSketch());
Expand Down Expand Up @@ -104,7 +103,10 @@ const Toolbar = (props) => {
return (
<p className="toolbar__project-project.owner">
{t('Toolbar.By')}{' '}
<Link to={`/${project.owner.username}/sketches`}>
<Link
className="toolbar__username"
to={`/${project.owner.username}/sketches`}
>
{project.owner.username}
</Link>
</p>
Expand Down
17 changes: 17 additions & 0 deletions client/styles/components/_toolbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,23 @@
}
}

.toolbar__username {
cursor: pointer;
@include themify() {
color: getThemifyVariable('secondary-text-color');

&:hover {
// Default hover color for light/dark theme
color: $p5-light-pink;

// If the logo color is yellow, override the hover color
@if (getThemifyVariable('logo-color') == $yellow) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one issue here is similar to the one I noted in your other PR, where we can use just the getThemifyVariable utility function directly rather than the conditional.

color: $yellow;
}
}
}
}

.toolbar__autorefresh-label {
cursor: pointer;
@include themify() {
Expand Down