Skip to content

Prevent hover state from sticking on mobile accessibility toggles #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksen0 merged 2 commits into from
Nov 7, 2025
Merged

Prevent hover state from sticking on mobile accessibility toggles #1017

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa5a7f3
fix hover accesibility toggle
Homaid Nov 4, 2025
e927d57
remove extra space
Homaid Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/components/Dropdown/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@
width: 100%;
height: 100%;
cursor: pointer;
&:hover {
border: 1px solid var(--accent-color);
background-color: var(--accent-type-color);
color: var(--accent-color);
@media (hover: hover) and (pointer: fine) {

@coseeian coseeian Nov 5, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align coding style in this file and fix indention of L23.

&:hover {
border: 1px solid var(--accent-color);
background-color: var(--accent-type-color);
color: var(--accent-color);
}
}

@coseeian coseeian Nov 5, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty line that is not necessary.

}

.options {
Expand Down Expand Up @@ -93,10 +96,13 @@
}
}

li[aria-selected="false"]:hover .icon {
svg {
background: var(--accent-type-color);
border-radius: 2rem;
// Only apply hover styles on devices with true hover capability (not touch devices)
@media (hover: hover) and (pointer: fine) {
li[aria-selected="false"]:hover .icon {
svg {
background: var(--accent-type-color);
border-radius: 2rem;
}
}
}

Expand Down