Repository navigation
Conversation
Author
|
Can you look onto this PR @ksen0 ? I am not sure if its the correct branch to merge to. Thank you! |
Member
|
I'm not 100% sure this is redundant/no needed. The override is specifically for using react component libraries (such as
Is that not the case? |
Author
|
Yeah it was my npm's issue, I recently updated and it's fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Changes
PR Checklist
npm run lintpassesProblem
Running
npm installfails with the following error:The
npm:@preact/compat@latestsyntax in theoverridessection ofpackage.jsoncauses compatibility issues, preventing contributors from installing dependencies.Solution
The Preact alias overrides are actually redundant. The Astro Preact integration automatically handles react compatibility using
compat: trueoption ofastro.config.mjs: