Add aria-live status messages for button actions to improve screen reader feedback (fixes issue #866) #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! My only question is about the timeout that is set in announce. As far as I can tell timeouts that are set are not cleared on unmount or when announce is called repeatedly. Does it make sense to add cleanup logic to handle potential race conditions? |
|
I think that's right, maybe we need to keep track of the timer id, and clear the timer when we update the content + on unmount via a useEffect cleanup function? |
|
I have already made the fix. Please review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #866.
After a button is pressed and the associated action is performed, a span container with aria-live is updated with a status message. This allows screen readers to announce feedback, ensuring that users receive confirmation when an action is completed.