Skip to content

print() function, even with content, causes print dialog to appear in… #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

debajitdeb11
Copy link

… firefox

fix

Resolves #4272

Changes:

  • Fix the issue of print dialog to appear in the browser by using the print() function.
  • Slight changes in the example section

@welcome
Copy link

welcome bot commented Feb 25, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@lmccart
Copy link
Member

lmccart commented Feb 25, 2020

Thanks! print() with content used inside setup and draw works as expected in firefox, and other browsers. So we want to keep the code as is, because we do want to invoke the print dialog if there's no content. The remaining todo on #4272 is to see if we can use the friendly error system to detect a pattern of print("content") outside of setup and draw.

@lmccart lmccart closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print("content") outside of setup/draw invokes print dialog. possible to catch with FES?
2 participants